-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(python): drop support for Python 3.6 and 3.7 (#683) #683
Conversation
@@ -140,6 +140,7 @@ | |||
}, | |||
include_package_data=True, | |||
extras_require=extras_require, | |||
python_requires=">=3.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like other components, what to do with python_requires
and classifiers
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See reanahub/reana-db#235 (comment)
I have kept only Python 3.8 in
setup.py
's classifiers and in the CI for non-shared components, and Python 3.8-3.12 for the shared ones (reana-db, reana-commons, reana-client, pytest-reana)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #683 +/- ##
==========================================
- Coverage 60.14% 59.46% -0.69%
==========================================
Files 32 32
Lines 3317 3298 -19
==========================================
- Hits 1995 1961 -34
- Misses 1322 1337 +15 |
BREAKING CHANGE: drop support for Python 3.6 and 3.7 Closes reanahub/reana#784
306e342
to
3a9f000
Compare
BREAKING CHANGE: drop support for Python 3.6 and 3.7 Closes reanahub/reana#784
3a9f000
to
868dee9
Compare
BREAKING CHANGE: drop support for Python 3.6 and 3.7
Closes reanahub/reana#784